[Mlir-commits] [mlir] [mlir][vector] Fix invalid IR in `ContractionOpLowering` (PR #78130)

Han-Chung Wang llvmlistbot at llvm.org
Mon Jan 15 16:51:57 PST 2024


================
@@ -458,49 +450,70 @@ struct UnrolledOuterProductGenerator
     return res;
   }
 
+  std::optional<int64_t> getReductionSize(VectorType vecType,
----------------
hanhanW wrote:

Can you add a doc to the method? Otherwise, people need to look at implementation to understand when `std::nullopt` will be returned.

https://github.com/llvm/llvm-project/pull/78130


More information about the Mlir-commits mailing list