[Mlir-commits] [mlir] Reformat whitespace in dependent dialects codegen (PR #78090)

Markus Böck llvmlistbot at llvm.org
Sun Jan 14 08:52:12 PST 2024


https://github.com/zero9178 commented:

Big fan of this change as an avid reader of TableGen generated code :slightly_smiling_face: 

One thing I am worried about are the tests. I don't think they provide a lot of benefits: They effectively only test whether the `insert` calls are one line after the other with no whitespace lines before or after and do not test indendation. 
At the same time they are probably prone to breakage if any future changes are done to the codegen of these methods.

I'd personally just remove the tests.

https://github.com/llvm/llvm-project/pull/78090


More information about the Mlir-commits mailing list