[Mlir-commits] [mlir] [mlir][TilingInterface] Move TilingInterface tests to use transform dialect ops. (PR #77204)

Quinn Dawkins llvmlistbot at llvm.org
Thu Jan 11 13:44:57 PST 2024


================
@@ -283,10 +283,7 @@ mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter, TilingInterface op,
   // 1. Get the range of the loops that are represented by the operation.
   SmallVector<Range> iterationDomain = op.getIterationDomain(rewriter);
   size_t numLoops = iterationDomain.size();
-  if (numLoops == 0) {
-    return rewriter.notifyMatchFailure(
-        op, "unable to tile op with no iteration domain");
-  }
+
----------------
qedawkins wrote:

Can you elaborate on what this is supposed to do to ops without an iteration domain? It looks like it's calling into `cloneOpAndUpdateDestinationArgs`, but since this will never generate any loops can we early return here to avoid the clone?

https://github.com/llvm/llvm-project/pull/77204


More information about the Mlir-commits mailing list