[Mlir-commits] [mlir] [TOSA] FFT2D operator (PR #77005)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Jan 11 05:56:44 PST 2024


tomnatan wrote:

There is a bug in mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp line 2375 :
```
ArrayRef<OpFoldResult> dims = tensor::getMixedSizes(rewriter, loc, input_real);
```

tensor::getMixedSizes returns a SmallVector so using an ArrayRef would mean the actual data will be destroyed as soon as this call is done.

You should either use auto or SmallVector<OpFoldResult>.

Also, can you add [[maybe_unused]] to imag_el_ty as it is only used in an assert? (line 2366)

Can you please fix?

https://github.com/llvm/llvm-project/pull/77005


More information about the Mlir-commits mailing list