[Mlir-commits] [mlir] [MLIR][Presburger] Implement computation of generating function for unimodular cones (PR #77235)

[Mehdi Amini]

================
@@ -63,3 +63,71 @@ MPInt mlir::presburger::detail::getIndex(ConeV cone) {
 
   return cone.determinant();
 }
+
+/// Compute the generating function for a unimodular cone.
+GeneratingFunction mlir::presburger::detail::unimodularConeGeneratingFunction(
----------------
joker-eph wrote:

> You would need to open the namespace ala:
> 
> ```c++
> namespace mlir {
>    // here you can drop the qualifiers for definitions
> }
> ```

This isn't as safe as fully-qualifying the functions.
When are `using namespace mlir;` and qualifying the namespace on the function definition, you get a compile-time error if there isn't a matching declaration in the header.

https://github.com/llvm/llvm-project/pull/77235