[Mlir-commits] [mlir] [MLIR][Presburger] Implement computation of generating function for unimodular cones (PR #77235)

[Bharathi Ramana Joshi]

================
@@ -63,3 +63,71 @@ MPInt mlir::presburger::detail::getIndex(ConeV cone) {
 
   return cone.determinant();
 }
+
+/// Compute the generating function for a unimodular cone.
+GeneratingFunction mlir::presburger::detail::unimodularConeGeneratingFunction(
----------------
iambrj wrote:

also there is another identifier called `detail` in the `mlir` namespace so I think you'll have to use `presburger::detail` even if you drop the `mlir::`
```
llvm-project/mlir/lib/Analysis/Presburger/Barvinok.cpp:18:7: error: reference to 'detail' is ambiguous
ConeV detail::getDual(ConeH cone) {
      ^
llvm-project/mlir/include/mlir/Support/TypeID.h:334:1: note: candidate found by name lookup is 'mlir::detail'
MLIR_DECLARE_EXPLICIT_TYPE_ID(void)
^
llvm-project/mlir/include/mlir/Support/TypeID.h:251:13: note: expanded from macro 'MLIR_DECLARE_EXPLICIT_TYPE_ID'
  namespace detail {                                                           \
            ^
llvm-project/mlir/include/mlir/Analysis/Presburger/Barvinok.h:33:11: note: candidate found by name lookup is 'mlir::presburger::detail'
namespace detail {
```

https://github.com/llvm/llvm-project/pull/77235