[Mlir-commits] [mlir] [MLIR][Presburger] Implement computation of generating function for unimodular cones (PR #77235)

Bharathi Ramana Joshi llvmlistbot at llvm.org
Sun Jan 7 09:03:08 PST 2024


================
@@ -63,3 +63,71 @@ MPInt mlir::presburger::detail::getIndex(ConeV cone) {
 
   return cone.determinant();
 }
+
+/// Compute the generating function for a unimodular cone.
----------------
iambrj wrote:

Not sure if this comment adds any value beyond the function name itself. From what I've seen, comments in `.cpp` files usually explain a function's implementation, comments in `.h` files usually explain what a function is for.

https://github.com/llvm/llvm-project/pull/77235


More information about the Mlir-commits mailing list