[Mlir-commits] [libc] [llvm] [mlir] [clang] [lldb] [NFC][ObjectSizeOffset] Use classes instead of std::pair (PR #76882)

[Bill Wendling]

bwendling wrote:

Actually, that fix was making all of the other builds fail:

```
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryBuiltins.h:279:47: error: specialization of ‘llvm::SizeOffsetType<llvm::Value*, llvm::SizeOffsetValue>’ after instantiation
  279 |   template <typename T, class C> friend class SizeOffsetType;
      |                                               ^~~~~~~~~~~~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryBuiltins.h:292:47: error: specialization of ‘llvm::SizeOffsetType<llvm::WeakTrackingVH, llvm::SizeOffsetWeakTrackingVH>’ after instantiation
  292 |   template <typename T, class C> friend class SizeOffsetType;
      |                                               ^~~~~~~~~~~~~~
32.474 [1989/19/1551] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AttributorAttributes.cpp.o
FAILED: lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AttributorAttributes.cpp.o 
ccache /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-dev-x86-64-b1/build/lib/Transforms/IPO -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/Transforms/IPO -I/b/ml-opt-dev-x86-64-b1/build/include -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include -isystem /tmp/tflitebuild/tensorflow/include -isystem /tmp/tflitebuild/eigen/include/eigen3 -isystem /tmp/tflitebuild/abseil-cpp/include -isystem /tmp/tflitebuild/flatbuffers/include -isystem /tmp/tflitebuild/gemmlowp/include/gemmlowp -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes/ml_dtypes -isystem /tmp/tflitebuild/ruy/include -isystem /tmp/tflitebuild/cpuinfo/include -isystem /tmp/tflitebuild/ARM_NEON_2_x86_SSE/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -std=c++17 -MD -MT lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AttributorAttributes.cpp.o -MF lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AttributorAttributes.cpp.o.d -o lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AttributorAttributes.cpp.o -c /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/Transforms/IPO/AttributorAttributes.cpp
In file included from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/Transforms/IPO/AttributorAttributes.cpp:35:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryBuiltins.h:217:47: error: specialization of ‘llvm::SizeOffsetType<llvm::APInt, llvm::SizeOffsetAPInt>’ after instantiation
  217 |   template <typename T, class C> friend class SizeOffsetType;
      |                                               ^~~~~~~~~~~~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryBuiltins.h:279:47: error: specialization of ‘llvm::SizeOffsetType<llvm::Value*, llvm::SizeOffsetValue>’ after instantiation
  279 |   template <typename T, class C> friend class SizeOffsetType;
      |                                               ^~~~~~~~~~~~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryBuiltins.h:292:47: error: specialization of ‘llvm::SizeOffsetType<llvm::WeakTrackingVH, llvm::SizeOffsetWeakTrackingVH>’ after instantiation
  292 |   template <typename T, class C> friend class SizeOffsetType;
      |                                               ^~~~~~~~~~~~~~
33.552 [1989/18/1552] Building AMDGPUGenMCPseudoLowering.inc...
```

So I don't know what can be done here. Is it possible for Visual Studio not to use a broken compiler?

https://github.com/llvm/llvm-project/pull/76882