[Mlir-commits] [mlir] [mlir][scf] Add simple LICM pattern for `scf.while` (PR #76370)

[Mehdi Amini]

joker-eph wrote:

> Here are few examples of transformations that were moved out of canonicalization over time because having more control over when transformations are applied was necessary:

Some of these aren't motivated, so it's hard to form an opinion. But when I read:

> The patterns to remove dead arguments and results of `linalg.generic` operations are not necessarily canonicalizations.

That seems completely bogus to me. If obvious dead code removal can't be a canonicalization, then we could just as well remove entirely the concept of canonicalization. 

https://github.com/llvm/llvm-project/pull/76370