[Mlir-commits] [clang-tools-extra] [libcxx] [compiler-rt] [flang] [libc] [lldb] [llvm] [polly] [mlir] [lld] [clang] [libcxxabi] Make clang report invalid target versions. (PR #75373)

Fangrui Song llvmlistbot at llvm.org
Fri Jan 5 16:27:44 PST 2024


================
@@ -786,4 +786,7 @@ def warn_android_unversioned_fallback : Warning<
   " directories will not be used in Clang 19. Provide a versioned directory"
   " for the target version or lower instead.">,
   InGroup<DiagGroup<"android-unversioned-fallback">>;
+
+def err_android_version_invalid : Error<
+  "Version %0 in triple %1-%2-%3-%4 is invalid.">;
----------------
MaskRay wrote:

See https://llvm.org/docs/CodingStandards.html#error-and-warning-messages

We can keep just `%1` and remove 2/3/4 by using `TC.getTripleString()` in the call site.

https://github.com/llvm/llvm-project/pull/75373


More information about the Mlir-commits mailing list