[Mlir-commits] [mlir] [MLIR] Add ODS support for generating helpers for dialect (discardable) attributes (PR #77024)

Jeff Niu llvmlistbot at llvm.org
Fri Jan 5 09:53:12 PST 2024


================
@@ -181,6 +196,37 @@ static const char *const operationInterfaceFallbackDecl = R"(
                                       mlir::OperationName opName) override;
 )";
 
+/// The code block for the discardable attribute helper.
+static const char *const discardableAttrHelperDecl = R"(
+    /// Helper to manage the discardable attribute `{1}`.
+    class {0}AttrHelper {{
+      mlir::StringAttr name;
+    public:
+      static constexpr llvm::StringLiteral getNameStr() {{
----------------
Mogball wrote:

What's the benefit of this "helper" pattern over just providing the string name directly?

https://github.com/llvm/llvm-project/pull/77024


More information about the Mlir-commits mailing list