[Mlir-commits] [mlir] [mlir] Initial patch to add an MPI dialect (PR #68892)

Christian Ulmann llvmlistbot at llvm.org
Fri Jan 5 09:03:08 PST 2024


https://github.com/Dinistro commented:

Dropped a bunch of nit comments, the general design makes a lot of sense to me.

One concern I'm having is the restriction to only work with memref types. While I understand that this is easier to work with, some users might not be able to work with memrefs and thus cannot use this dialect. AFAIK, flang doesn't use memrefs, and neither does code that will come from some lower level input (or the LLVM import).
Note that this can also be resolved once this has been landed, though.

I think this is looking good to me, but I don't have the authority to accept this, I think. @kiranchandramohan @rengolin any idea who has the authority? 

https://github.com/llvm/llvm-project/pull/68892


More information about the Mlir-commits mailing list