[Mlir-commits] [mlir] [MLIR][Presburger] Implement IntegerRelation::mergeAndAlignSymbols (PR #76736)

[llvmlistbot at llvm.org]

================
@@ -1288,6 +1288,38 @@ void IntegerRelation::eliminateRedundantLocalVar(unsigned posA, unsigned posB) {
   removeVar(posB);
 }
 
+/// First merge and align identifiers into `other` from `this`. If an identifier
+/// exists in `other`, then align it; otherwise insert it assuming it is a new
+/// identifier. Then add identifiers that are in `other`, but not in `this` to
+/// `this`.
+void IntegerRelation::mergeAndAlignSymbols(IntegerRelation &other) {
+  assert(space.isUsingIds() && other.space.isUsingIds() &&
+         "Both relations need to have identifers to merge and align");
----------------
Abhinav271828 wrote:

nit: I believe [the LLVM standard](https://llvm.org/docs/CodingStandards.html#error-and-warning-messages) is for error messages to start with a lowercase letter.

https://github.com/llvm/llvm-project/pull/76736