[Mlir-commits] [mlir] Implement `insertVar` having `Identifier` parameter (PR #76993)

Kunwar Grover llvmlistbot at llvm.org
Fri Jan 5 01:31:13 PST 2024


https://github.com/Groverkss requested changes to this pull request.

Thank you for the patch! Help is very welcome :) I have two requests:

1. Could you please add some unit tests? Presburger lib unit tests live in mlir/unittests/Analysis/Presburger. You should be able to find some Identifier tests there.
2. Could we keep this patch restricted to Presburger lib for now? I mentioned the exact place where we shouldn't expose it for now as a comment with more explanation.

https://github.com/llvm/llvm-project/pull/76993


More information about the Mlir-commits mailing list