[Mlir-commits] [mlir] [mlir] add a way to query non-property attributes (PR #76959)

Mehdi Amini llvmlistbot at llvm.org
Thu Jan 4 07:04:40 PST 2024


================
@@ -500,6 +500,12 @@ class alignas(8) Operation final
                                llvm::to_vector(getDiscardableAttrs()));
   }
 
+  /// Return all attributes that are not stored as properties.
+  DictionaryAttr getNonPropertyAttrDictionary() {
+    return getPropertiesStorage() ? getDiscardableAttrDictionary()
+                                  : getAttrDictionary();
----------------
joker-eph wrote:

Ah I see, somehow I thought `getAttrDictionary` would end up with `return attrs;`

Can we name this `getRawDictionaryAttrs()` and implement it as `return attrs;`?

https://github.com/llvm/llvm-project/pull/76959


More information about the Mlir-commits mailing list