[Mlir-commits] [mlir] [mlir] add a way to query non-property attributes (PR #76959)

[Oleksandr Alex Zinenko]

================
@@ -500,6 +500,12 @@ class alignas(8) Operation final
                                llvm::to_vector(getDiscardableAttrs()));
   }
 
+  /// Return all attributes that are not stored as properties.
+  DictionaryAttr getNonPropertyAttrDictionary() {
----------------
ftynse wrote:

I don't like it much either. However, we got into a situation that conflates inherent/discardable attributes and properties. In particular, a lot of downstreams that haven't migrated to properties, as well as some pieces of upstream, incorrectly assume that all attributes are discardable because `getDiscardableAttrs` used to return inherent attributes when properties were not used.

https://github.com/llvm/llvm-project/pull/76959