[Mlir-commits] [mlir] [mlir][RegionBranchOpInterface] explicitly check for existance of block terminator (PR #76831)

Markus Böck llvmlistbot at llvm.org
Wed Jan 3 08:57:56 PST 2024


https://github.com/zero9178 commented:

I haven't thought about the semantics of this too much yet, but I think that at the very least there should be a test verifying that such a `RegionBranchOpInterface` does now verify correctly. You could add such an op in the test dialect.
I think this is especially important here as we are supporting a new use-case to avoid regressions and other code making assumptions about the presence of terminators.

https://github.com/llvm/llvm-project/pull/76831


More information about the Mlir-commits mailing list