[Mlir-commits] [mlir] [mlir][GPU] Expand LLVM function attribute copies (PR #76755)

Jakub Kuderski llvmlistbot at llvm.org
Tue Jan 2 13:54:26 PST 2024


================
@@ -194,18 +194,22 @@ GPUFuncOpLowering::matchAndRewrite(gpu::GPUFuncOp gpuFuncOp, OpAdaptor adaptor,
   // Get memref type from function arguments and set the noalias to
   // pointer arguments.
   for (const auto &en : llvm::enumerate(gpuFuncOp.getArgumentTypes())) {
----------------
kuhar wrote:

nit: while we are at this, we could make this a bit more readable 
```suggestion
  for (auto [idx, argType] : llvm::enumerate(gpuFuncOp.getArgumentTypes())) {
```
(this is existing code, so feel free to leave as-is)

https://github.com/llvm/llvm-project/pull/76755


More information about the Mlir-commits mailing list