[Mlir-commits] [mlir] [MLIR][LLVM] Support Recursive DITypes (PR #80251)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for moving this foward! I did another pass mostly adding nit comments. 

After looking at the import again I wonder if we could use `DIRecursiveTypeAttrOf` for the composite type only to avoid some of the casting. I would probably also drop the `nonTypeTranslationStack` since it seems unused for now. Plus I am not really aware of a use case?

I wonder if there is another recursive type. Maybe subroutine type? If yes we could use that one to keep some of the deleted tests alive. Over time some of the checks / nullptr handling we introduced types can then be deleted. However, that will for sure be something for a follow up once we have more experience with this approach.

https://github.com/llvm/llvm-project/pull/80251