[Mlir-commits] [mlir] [mlir][NFC] Apply rule of five to *Pass classes (PR #80998)

Mehdi Amini llvmlistbot at llvm.org
Thu Feb 29 09:43:17 PST 2024


joker-eph wrote:

> Although, technically, @zero9178 is right that explicitly deleting member functions could actually break compilation

I thought these were implicitly deleted right now?

>  - which makes me question the "NFC" label

NFC is about the behavior of the compiler, changing APIs is just "business as usual" (any NFC refactoring we do is breaking C++ APIs).



https://github.com/llvm/llvm-project/pull/80998


More information about the Mlir-commits mailing list