[Mlir-commits] [mlir] [mlir][NFC] Apply rule of five to *Pass classes (PR #80998)
Andrei Golubev
llvmlistbot at llvm.org
Thu Feb 29 05:24:47 PST 2024
andrey-golubev wrote:
> Please update the title to add (NFC)
>
> Also update the description to reflect the last revision and be explicit on the fact that this is just making explicit the current state.
Took me a while to get back to this! Updated as request. Although, technically, @zero9178 is right that explicitly deleting member functions could actually break compilation - which makes me question the "NFC" label. Yet, given the nature of these classes, it seems like the intended behavior is exactly to create them via smart pointers + having a copy-ctor as a very special way to allow custom behavior during cloning (e.g. look at `PassWrapper::clonePass()` which is a virtual function override and then there are similar facilities in other places).
https://github.com/llvm/llvm-project/pull/80998
More information about the Mlir-commits
mailing list