[Mlir-commits] [mlir] [MLIR][LLVM] Support Recursive DITypes (PR #80251)

[Tobias Gysi]

https://github.com/gysit commented:

I looked only at the translation back to LLVM IR this time.

I think the translation makes sense. I added some minor comments that may or may not be comprehensible / correct given the time of the day here :).

It is definitely not super easy to follow the logic due to assumptions on the structure and the recursive single pass approach. Would it theoretically be possible to do this in two passes? A first pass that creates the place holders and a second pass that fixes all place holders? But yeah even if it works it is probably also non-trivial.



https://github.com/llvm/llvm-project/pull/80251