[Mlir-commits] [mlir] [mlir] Don't rely on values of MLIR_(CURDA|ROCM)_CONVERSIONS_ENABLED. (PR #82988)

[Ingo Müller]

ingomueller-net wrote:

OK, that's a good argument. That might have caught #83004 -- I'll try out running with that warning flag and see if I find similar problems.

One clarification, though: even if we use `#if` instead of `#ifdef`, we don't have to rely on a value, right? That would prefer `#if X` over `#if X == 1`. Is that so?

FWIW, I think our downstream problems were actually unrelated to the macro value.

https://github.com/llvm/llvm-project/pull/82988