[Mlir-commits] [mlir] [AMDGPU] Add parameterization for optimized shared memory variables (PR #82508)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Feb 26 17:47:30 PST 2024


================
@@ -253,4 +278,8 @@ struct OptimizeSharedMemoryPass
         return;
     }
   }
+
+private:
+  int64_t _kSharedMemoryLineSizeBytes;
----------------
harsh-amd wrote:

Not sure if this leading underscore is LLVM style. But you shouldn't need it anyway if you get rid of the globals.

https://github.com/llvm/llvm-project/pull/82508


More information about the Mlir-commits mailing list