[Mlir-commits] [mlir] [mlir] Don't rely on values of MLIR_(CURDA|ROCM)_CONVERSIONS_ENABLED. (PR #82988)

Mehdi Amini llvmlistbot at llvm.org
Mon Feb 26 16:53:03 PST 2024


https://github.com/joker-eph requested changes to this pull request.

I have concerns with this direction which seems the opposite of what we should do.

I would want to never use `ifdef` so that we can turn on the `-Wundef` warning and catch the usual misconfiguration problem where there are spelling issue, or a macro is renamed and usage not updated, etc.


https://github.com/llvm/llvm-project/pull/82988


More information about the Mlir-commits mailing list