[Mlir-commits] [mlir] Fix textual/bytecode roundtrip for SPIRV_LinkageAttributesAttr (PR #82951)

Matteo Franciolini llvmlistbot at llvm.org
Sun Feb 25 19:30:24 PST 2024


mfrancio wrote:

> I think #82953 would achieve the same thing? (seems like a better fix to me)

Yeah, i agree with that :) 

Is there a convention for dialects to follow about attributes? It seems like this dialect is built around non-attribute parameters and printers/parsers seem to work somewhat coincidentally, as this soon-to-close patch is highlighting.

https://github.com/llvm/llvm-project/pull/82951


More information about the Mlir-commits mailing list