[Mlir-commits] [mlir] 9767807 - Apply clang-tidy fixes for readability-container-size-empty in SerializeROCDLTarget.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Sun Feb 25 17:05:54 PST 2024


Author: Mehdi Amini
Date: 2024-02-25T17:05:29-08:00
New Revision: 97678078442adbd6c12cc54f7a36152f8873afb4

URL: https://github.com/llvm/llvm-project/commit/97678078442adbd6c12cc54f7a36152f8873afb4
DIFF: https://github.com/llvm/llvm-project/commit/97678078442adbd6c12cc54f7a36152f8873afb4.diff

LOG: Apply clang-tidy fixes for readability-container-size-empty in SerializeROCDLTarget.cpp (NFC)

Added: 
    

Modified: 
    mlir/unittests/Target/LLVM/SerializeROCDLTarget.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/unittests/Target/LLVM/SerializeROCDLTarget.cpp b/mlir/unittests/Target/LLVM/SerializeROCDLTarget.cpp
index 3d9d8175b115ed..e91e69b102043a 100644
--- a/mlir/unittests/Target/LLVM/SerializeROCDLTarget.cpp
+++ b/mlir/unittests/Target/LLVM/SerializeROCDLTarget.cpp
@@ -89,7 +89,7 @@ TEST_F(MLIRTargetLLVMROCDL, SKIP_WITHOUT_AMDGPU(SerializeROCDLMToLLVM)) {
         serializer.serializeToObject(gpuModule, options);
     // Check that the serializer was successful.
     ASSERT_TRUE(object != std::nullopt);
-    ASSERT_TRUE(object->size() > 0);
+    ASSERT_TRUE(!object->empty());
 
     // Read the serialized module.
     llvm::MemoryBufferRef buffer(StringRef(object->data(), object->size()),
@@ -125,7 +125,7 @@ TEST_F(MLIRTargetLLVMROCDL, SKIP_WITHOUT_AMDGPU(SerializeROCDLToPTX)) {
         serializer.serializeToObject(gpuModule, options);
     // Check that the serializer was successful.
     ASSERT_TRUE(object != std::nullopt);
-    ASSERT_TRUE(object->size() > 0);
+    ASSERT_TRUE(!object->empty());
 
     ASSERT_TRUE(
         StringRef(object->data(), object->size()).contains("rocdl_kernel"));


        


More information about the Mlir-commits mailing list