[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)
Stella Laurenzo
llvmlistbot at llvm.org
Fri Feb 23 15:45:38 PST 2024
stellaraccident wrote:
I agree that there is technically not a circular dependency. I strongly prefer some kind of notion of "splitting the library". The way I proposed (effectively creating a sub-library of interface identities) is one. Another would be to have a separate tree for "public" dialect interfaces and everyone (including the dialect) depends on that. Eg:
```
mlir/Interfaces/Bufferization/Interface.h
```
Downstreams can do what they want, but I think that upstream should encourage some clean layering: in this case making the thing that must be shared to refer to a shared interface separate (in terms of tree and dag) in some way.
https://github.com/llvm/llvm-project/pull/78368
More information about the Mlir-commits
mailing list