[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Mehdi Amini llvmlistbot at llvm.org
Thu Feb 22 02:10:11 PST 2024


joker-eph wrote:

> Now if it had promises, project setup would have to provide implementations for those promises

I don't follow how you reach this conclusion?
The point of promises is that you need to provide an implementations **if and only if** you will actually need them. This should be fully decoupled, otherwise I don't quite get the point of the promise if the coupling still exists...

>  I think it's wrong to have IR depend on Transform, 

I agree, but this isn't a dependency when this is about interfaces, this is basically "we need to know this class exists and get its name" IIUC?




https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list