[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

[Mehdi Amini]

joker-eph wrote:

> Assuming it's not the dialect itself that declares the promise

that doesn’t lineup with your previous message I was quoting:

> I'm not sure having a promised interface for the builtin dialect even makes sense. 

That is: it was about the built in dialect declaring the promise, but now you start with assuming the opposite: what do I miss?

> I think we removed most of these

Really? I was pretty sure of the opposite. I will have a look at the Bazel file: less than a year ago they were still getting patched to work around this kind of header deps.

Just look at the mlir/IR includes: I am pretty sure they include other directories (and everything depends on IR…)

https://github.com/llvm/llvm-project/pull/78368