[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Mehdi Amini llvmlistbot at llvm.org
Mon Feb 19 15:55:36 PST 2024


joker-eph wrote:

> I'm not sure having a promised interface for the builtin dialect even makes sense. If there is an interface that needs to be added to builtin, I suppose the place that defines the interface should immediately register it. 

I don't follow why?

> Builtin is always loaded in the context and lives in lib/IR so pretty much everything depends on it. 

But the logic remains the same as for the other dialects: if I don't plan to use the transformation that requires interface Foo, why would I need to have the implementation for interface Foo automatically present in my binary and loaded with the builtin dialect?

https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list