[Mlir-commits] [mlir] eb0c8de - Apply clang-tidy fixes for llvm-else-after-return in SerializeOps.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Thu Feb 15 16:03:27 PST 2024


Author: Mehdi Amini
Date: 2024-02-15T16:02:41-08:00
New Revision: eb0c8de1eed7c8198e397c56aa12b30abad42cf5

URL: https://github.com/llvm/llvm-project/commit/eb0c8de1eed7c8198e397c56aa12b30abad42cf5
DIFF: https://github.com/llvm/llvm-project/commit/eb0c8de1eed7c8198e397c56aa12b30abad42cf5.diff

LOG: Apply clang-tidy fixes for llvm-else-after-return in SerializeOps.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp b/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
index 41d2c0310d0008..e68ed5efaca746 100644
--- a/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
+++ b/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
@@ -247,7 +247,8 @@ LogicalResult Serializer::processFuncOp(spirv::FuncOp op) {
     return op.emitError(
         "'spirv.module' cannot contain external functions "
         "without 'Import' linkage_attributes (LinkageAttributes)");
-  } else if (op.isExternal() && hasImportLinkage) {
+  }
+  if (op.isExternal() && hasImportLinkage) {
     // Add an entry block to set up the block arguments
     // to match the signature of the function.
     // This is to generate OpFunctionParameter for functions with


        


More information about the Mlir-commits mailing list