[Mlir-commits] [mlir] [mlir][AMDGPU] Set uniform-work-group-size=true by default (PR #79077)

Fabian Mora llvmlistbot at llvm.org
Thu Feb 15 07:36:14 PST 2024


================
@@ -134,7 +140,19 @@ class ROCDLDialectLLVMIRTranslationInterface
       llvmAttrValue.append(value.getValue());
       llvmFunc->addFnAttr("amdgpu-flat-work-group-size", llvmAttrValue);
     }
-
+    if (ROCDL::ROCDLDialect::getUniformWorkGroupSizeAttrName() ==
+        attribute.getName()) {
+      auto func = dyn_cast<LLVM::LLVMFuncOp>(op);
+      if (!func)
+        return failure();
----------------
fabianmcg wrote:

Can we add here an `emitError` indicating why it is failing?

https://github.com/llvm/llvm-project/pull/79077


More information about the Mlir-commits mailing list