[Mlir-commits] [flang] [mlir] [openmp] [Flang][OpenMP][MLIR] Extend derived (record) type map support in Flang and OpenMP dialect (PR #81328)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Feb 9 15:16:16 PST 2024


agozillon wrote:

> > > Please split the patch appropriately into flang lowering, mlir dialect changes, mlir to LLVM IR lowering.
> > 
> > 
> > Will do, thought it might be helpful to have the larger PR up as a larger reference for the overall scope/discussion alongside running the in PR tests correctly (individually the PRs fragmented will not pass the tests, unless there's a way to stack PRs as on phabricator, which there might be now)! I'll do so on Monday.
> 
> Fine. No hurry.
> 
> > Would you prefer the runtime related tests (the end to end tests that fall into the openmp/libomptarget/test/offloading/fortran/ directory) in a seperate PR or in the Flang lowering PR?
> 
> Separate.

Thank you, sounds good! I'll aim for four interlinked PRs then:
    > flang lowering
    >  mlir dialect changes
    >  mlir to LLVM IR lowering
    > fortran openmp runtime tests 

Sorry for the bother! 

As an aside, does anyone know of a way to stack dependent patches similar to Phabricator for the purposes of passing the in PR CI tests?

https://github.com/llvm/llvm-project/pull/81328


More information about the Mlir-commits mailing list