[Mlir-commits] [mlir] 7fd1466 - [mlir] Fix CallOpInterface extraClassDeclaration to be fully namespace qualified (#81258)

[llvmlistbot at llvm.org]

Author: Richard Dzenis
Date: 2024-02-09T13:07:07-08:00
New Revision: 7fd1466433a05f4e2e183914a8bd7c372bb0b8a7

URL: https://github.com/llvm/llvm-project/commit/7fd1466433a05f4e2e183914a8bd7c372bb0b8a7
DIFF: https://github.com/llvm/llvm-project/commit/7fd1466433a05f4e2e183914a8bd7c372bb0b8a7.diff

LOG: [mlir] Fix CallOpInterface extraClassDeclaration to be fully namespace qualified (#81258)

`extraClassDeclaration` of `CallOpInterface` can be inherited by other
`OpInterfaces` into foreign namespaces, thus types must be fully
qualified to prevent compiler errors, for example:

    def MyCaller : OpInterface<"MyCaller", [CallOpInterface]> {
        let cppNamespace = "::MyNamespace";
    }

Added: 
    

Modified: 
    mlir/include/mlir/Interfaces/CallInterfaces.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Interfaces/CallInterfaces.td b/mlir/include/mlir/Interfaces/CallInterfaces.td
index 3e9c002b22ed69..752de74e6e4d7e 100644
--- a/mlir/include/mlir/Interfaces/CallInterfaces.td
+++ b/mlir/include/mlir/Interfaces/CallInterfaces.td
@@ -68,7 +68,7 @@ def CallOpInterface : OpInterface<"CallOpInterface"> {
     /// `symbolTable` is an optional parameter that will allow for using a
     /// cached symbol table for symbol lookups instead of performing an O(N)
     /// scan.
-    Operation *resolveCallable(SymbolTableCollection *symbolTable = nullptr);
+    ::mlir::Operation *resolveCallable(::mlir::SymbolTableCollection *symbolTable = nullptr);
   }];
 }