[Mlir-commits] [flang] [mlir] [WIP] Delayed privatization. (PR #79862)

[Tom Eccles]

================
@@ -3505,6 +3505,18 @@ struct ZeroOpConversion : public FIROpConversion<fir::ZeroOp> {
   }
 };
 
+class DeclareOpConversion : public FIROpConversion<fir::DeclareOp> {
----------------
tblah wrote:

I am surprised by this. In a quick experiment `flang-new -mmlir -mlir-pass-statistics -c [...]` gives me the same output both with and without `-fopenmp`. Why isn't `CodeGenRewrite` doing the job for you? This pass should run earlier than `FIRToLLVMLowering` (`CodeGen.cpp`).  

In @jeanPerier's commit adding `fir::DeclareOp` to `PreCGRewrite.cpp`, he mentions that it was placed here to avoid adding support for `fir.shape` to codegen.  See c852174a49

https://github.com/llvm/llvm-project/pull/79862