[Mlir-commits] [mlir] [mlir] Introduce wrapInZeroTripCheck in LoopLikeOpInterface (PR #80331)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

Late to the party here, but I think these transformations dont belong in the interface. Looking at the `LoopLikeOpInterface` it is actually doing some very heavy weight transformations that not all loop ops that implement this interface can handle. I tried to do this too in an earlier PR, and it was rightly pointed out that those kind of transformations dont go into the interface definition. 

Instead of adding oto the interface definition, maybe these are just transformation methods that are written on the interface. My read of interfaces are that they are a wrapper around the core operation to have a unified way to interpret operations. Adding transformations of this kind to an interface seem odd to me.

I am not pointing out something really off in this specific PR, but it is contributing to an aspect of the interface that I wanted to flag.

https://github.com/llvm/llvm-project/pull/80331