[Mlir-commits] [mlir] [mlir][Transforms][NFC] Improve listener layering in dialect conversion (PR #80825)

Matthias Springer llvmlistbot at llvm.org
Wed Feb 7 00:54:48 PST 2024


================
@@ -582,7 +582,8 @@ class AwaitOpLoweringBase : public OpConversionPattern<AwaitType> {
     // Inside regular functions we use the blocking wait operation to wait for
     // the async object (token, value or group) to become available.
     if (!isInCoroutine) {
-      ImplicitLocOpBuilder builder(loc, op, &rewriter);
+      ImplicitLocOpBuilder builder(loc, rewriter);
+      builder.setInsertionPoint(op);
----------------
matthias-springer wrote:

You're right, this line is not needed. I didn't check what the insertion point of the rewriter was. It is also `op`.


https://github.com/llvm/llvm-project/pull/80825


More information about the Mlir-commits mailing list