[Mlir-commits] [mlir] [mlir][Vectorizer] Added support to Vectorize tensor.unpack (PR #76087)

[Han-Chung Wang]

https://github.com/hanhanW requested changes to this pull request.

A high-level comment: IMO, `inputVectorSizes` should be in unpacked domain (i.e., it is for dest shapes). In this context, the behavior will be aligned with tiling. The tile_sizes in TilingInterface implementations are provided for unpacked domain (i.e., dest shape). E.g.,

https://github.com/llvm/llvm-project/blob/adbf21f12b3069b2554efb39f2e92c6cf6f24940/mlir/test/Dialect/Tensor/tiling.mlir#L401-L446

I think we really need them being aligned. Otherwise it leads to a lot of corner cases that play with other passes. E.g., IREE CPU backend has lowering_config. We use the tile_sizes to decide input_vector_sizes. If they don't match, you will have to implement other logics to make them align.

https://github.com/llvm/llvm-project/pull/76087