[Mlir-commits] [mlir] [mlir][ArmSME] Support 4-way widening outer products (PR #79288)

[Cullen Rhodes]

================
@@ -31,6 +31,55 @@ using namespace mlir;
 using namespace mlir::arm_sme;
 
 namespace {
+
+// Common match failure reasons.
+static constexpr StringLiteral
+    MATCH_FAILURE_NO_ACCUMULATOR("no accumulator operand");
----------------
c-rhodes wrote:

>Just an aside/observation: MLIR is not following the LLVM coding standards exactly, it's a mish-mash of Google style + LLVM style (but follows neither exactly), in both new and old code.

Yeah I noticed in that doc it says variables start with upper case but that's not true in MLIR. Anyhow, for this particular case, I can't see anywhere else that uses upper case for constexpr like this so I'll change to camel case given it's prevalent.

https://github.com/llvm/llvm-project/pull/79288