[Mlir-commits] [mlir] [mlir][emitc] Add a `declare_func` operation (PR #80297)

Marius Brehler llvmlistbot at llvm.org
Mon Feb 5 08:05:35 PST 2024


marbre wrote:

> > For now I added a verifier that checks if the parent is a `ModuleOp`. However, I am not sure if this is too restrictive. E.g. what about function declarations within IREE's VM modules @simon-camp? Is this still something we want or need to do? If though, I would rather drop to model this restriction as part of the IR and would rather go for a validator.
> 
> I would leave this out for now and see how it works out. Seems easier to add restrictions later.

I dropped the change and will add it to our todo list for the validation pass.

https://github.com/llvm/llvm-project/pull/80297


More information about the Mlir-commits mailing list