[Mlir-commits] [mlir] [mlir][EmitC] Drop unused code (NFC) (PR #80325)

Marius Brehler llvmlistbot at llvm.org
Sun Feb 4 09:51:41 PST 2024


marbre wrote:

> Looks like I meant to follow the SCFToCF example but left out the `let constructor = ...` line, which would have used the removed function in the `register` function. Anyway, seems there's no need to override the auto-generated constructor, so LGTM. Thanks for fixing this @marbre !

Very gladly. Yes, this is likely the case. I nearly implemented something similar for FuncToEmitC and that is why I actually spotted this.

https://github.com/llvm/llvm-project/pull/80325


More information about the Mlir-commits mailing list