[Mlir-commits] [mlir] [acc] Add attribute for combined constructs (PR #80319)

[Valentin Clement バレンタイン クレメン]

================
@@ -989,7 +1008,8 @@ def OpenACC_ParallelOp : OpenACC_Op<"parallel",
 
   let assemblyFormat = [{
     oilist(
-        `dataOperands` `(` $dataClauseOperands `:` type($dataClauseOperands) `)`
+        `combined` `(` custom<CombinedConstructs>($combined) `)`
----------------
clementval wrote:

I think it makes sense to look for uniforming when querying the information but we should probably to that through an interface so it is robust. I actually would like to introduce some interfaces for couple of things that some operations share so that we can enforce uniformity. We might leave it for another patch. 

I still find the UnitAttr approach more elegant (quick bool query + no custom parser/printer)  but it's not a blocker if you don't like it. 

https://github.com/llvm/llvm-project/pull/80319