[Mlir-commits] [mlir] [flang] [mlir][openacc] Add legalize data pass for compute operation (PR #80351)

[Razvan Lupusoru]

https://github.com/razvanlupusoru approved this pull request.

Looks great! Implementation looks much cleaner than I imagined.

I do think that the ssa uses for private/reduction/firstprivate operations should also be replaced. This means that the logic would also need to apply to acc.loop in addition to the compute constructs. This should be added also under an option just like you did for hostToDevice.

I would say this is OK to submit as-is - and we can make the improvement when it is needed. Nice work! Thank you for getting this done :)

https://github.com/llvm/llvm-project/pull/80351