[Mlir-commits] [mlir] [flang] [WIP] Delayed privatization. (PR #79862)

Leandro Lupori llvmlistbot at llvm.org
Thu Feb 1 11:40:44 PST 2024


================
@@ -187,8 +188,10 @@ def ParallelOp : OpenMP_Op<"parallel", [
              Variadic<AnyType>:$allocate_vars,
              Variadic<AnyType>:$allocators_vars,
              Variadic<OpenMP_PointerLikeType>:$reduction_vars,
+             Variadic<AnyType>:$private_vars,
              OptionalAttr<SymbolRefArrayAttr>:$reductions,
-             OptionalAttr<ProcBindKindAttr>:$proc_bind_val);
+             OptionalAttr<ProcBindKindAttr>:$proc_bind_val,
+             OptionalAttr<SymbolRefArrayAttr>:$private_inits);
----------------
luporl wrote:

Does each element of `private_inits` correspond to a PrivateClauseOp?
If this is the case, I think that a name like `private_ops` or `privatizers` would make it clearer what this attributes array is supposed to contain. The `_inits` suffix makes me think it holds the symbols from which values the privatized vars will be initialized.

https://github.com/llvm/llvm-project/pull/79862


More information about the Mlir-commits mailing list