[Mlir-commits] [mlir] [mlir][EmitC] Drop unused code (NFC) (PR #80325)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Feb 1 11:00:41 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Marius Brehler (marbre)

<details>
<summary>Changes</summary>

To register the conversion the autogenerated function `registerSCFToEmitC()` calls `createSCFToEmitC()`, which itself is also autogenerated. The removed function, however, isn't used in the upstream codebase.

---
Full diff: https://github.com/llvm/llvm-project/pull/80325.diff


2 Files Affected:

- (modified) mlir/include/mlir/Conversion/SCFToEmitC/SCFToEmitC.h (-4) 
- (modified) mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp (-4) 


``````````diff
diff --git a/mlir/include/mlir/Conversion/SCFToEmitC/SCFToEmitC.h b/mlir/include/mlir/Conversion/SCFToEmitC/SCFToEmitC.h
index 7ff682293f48b..22df7f1c5dcf2 100644
--- a/mlir/include/mlir/Conversion/SCFToEmitC/SCFToEmitC.h
+++ b/mlir/include/mlir/Conversion/SCFToEmitC/SCFToEmitC.h
@@ -20,10 +20,6 @@ class RewritePatternSet;
 
 /// Collect a set of patterns to convert SCF operations to the EmitC dialect.
 void populateSCFToEmitCConversionPatterns(RewritePatternSet &patterns);
-
-/// Creates a pass to convert SCF operations to the EmitC dialect.
-std::unique_ptr<Pass> createConvertSCFToEmitCPass();
-
 } // namespace mlir
 
 #endif // MLIR_CONVERSION_SCFTOEMITC_SCFTOEMITC_H
diff --git a/mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp b/mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp
index bf69ba503f4e6..367142a520742 100644
--- a/mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp
+++ b/mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp
@@ -199,7 +199,3 @@ void SCFToEmitCPass::runOnOperation() {
           applyPartialConversion(getOperation(), target, std::move(patterns))))
     signalPassFailure();
 }
-
-std::unique_ptr<Pass> mlir::createConvertSCFToEmitCPass() {
-  return std::make_unique<SCFToEmitCPass>();
-}

``````````

</details>


https://github.com/llvm/llvm-project/pull/80325


More information about the Mlir-commits mailing list