[Mlir-commits] [mlir] [MLIR] Prevent invalid IR from being passed outside of RemoveDeadValues (PR #121079)

[Andrzej Warzyński]

================
@@ -588,22 +644,68 @@ static void cleanBranchOp(BranchOpInterface branchOp, RunLivenessAnalysis &la) {
       operandValues.push_back(successorOperands[operandIdx]);
     }
 
-    BitVector successorLiveOperands = markLives(operandValues, la);
-
----------------
banach-space wrote:

Hm, looks like this is invalidating this comment:
> // 2. For each successor block:
> //    a. Retrieve the operands passed to the successor.
> //    b. Use the provided liveness analysis (`RunLivenessAnalysis`) to determine
> //       which operands are live in the successor block.
> //    c. Mark each operand as live or dead based on the analysis.

Right now, (2) simply collects all operands of all successors?

https://github.com/llvm/llvm-project/pull/121079