[Mlir-commits] [mlir] [mlir][vector] Canonicalize gathers/scatters with trivial offsets (PR #117939)

[Andrzej Warzyński]

banach-space wrote:

> Actually, I think, better approach may be to have a special StepElementsAttr in the same way we already have SplatElementsAttr, which is "canonicalized" on DenseElementsAttr construction like SplatElementsAttr. This way we don't need any special ops and users which doesn't know or doesn't care about StepElementsAttr can still work with it as normal dense constant.

Supporting `vector.step` is important - that's the only option for scalable vectors. In fact, since you added support for `vector.step`,  your changes should also work for scalable vectors.

https://github.com/llvm/llvm-project/pull/117939