[Mlir-commits] [mlir] [MLIR] Prevent invalid IR from being passed outside of RemoveDeadValues (PR #121079)
Renat Idrisov
llvmlistbot at llvm.org
Mon Dec 30 14:48:48 PST 2024
parsifal-47 wrote:
> Thanks!
>
> I've quickly skimmed through and left a few comments, but I will need more time for a proper review. This is a bit more involved than I expected - thank you so much for working on this! Main high-level comment:
>
> * there should be a very clear distinction between `deletionSet` and `cleanupList`.
>
> I've left a suggestion inline.
>
> Otherwise, this looks like the right approach to me :)
sure, I agree with your comments and will follow-up on resolutions
https://github.com/llvm/llvm-project/pull/121079
More information about the Mlir-commits
mailing list