[Mlir-commits] [mlir] [mlir] Attempt to resolve edge cases in PassPipeline textual format (PR #118877)

[Christopher Bate]

christopherbate wrote:

Sorry just saw the post-merge discussion. 

> This PR seems to change the behavior of a string option with no default, when passing the empty string my-pass{option=}. Is it expected that this means you cannot override an unset string option with an empty string?

I don't think it was intended that the syntax be changed for plain string options. An option of type `std::string` with no default has an empty string value, however (because it gets default-constructed).

> It seems that to define an empty string I have to actually use the list={} syntax, which is strange (it's even strange that list={} allows this given the option is not typed as a list).

The example you gave in your last message is a `ListOption`? Are you saying there's a problem with `Option<...., "std::string",...>` or `ListOption<..., "std::string",...>`?




https://github.com/llvm/llvm-project/pull/118877